- 
                Notifications
    You must be signed in to change notification settings 
- Fork 135
enable input metrics #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            enable input metrics #578
Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    kenhys
  
              
              approved these changes
              
                  
                    May 20, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
| When v1.19 is ready, deploy it! | 
0129dde    to
    ce48ad9      
    Compare
  
    
    
  daipom 
      added a commit
        to fluent/fluentd
      that referenced
      this pull request
    
      May 21, 2025 
    
    
      
  
    
      
    
  
**Which issue(s) this PR fixes**: Fixes # **What this PR does / why we need it**: I ran fluend with `--enable-input-metrics` option and read 10GB file with the `in_tail` plugin There was no significant performance degradation. So, I think it is safe to always enable `--enable-input-metrics`. ### environment * ruby 3.4.3 (2025-04-14 revision d0b7e5b6a0) +PRISM [x86_64-linux] ### results * fluentd master branch (efbb51d) * `ruby bin/fluentd -c in_tail.conf` * 65.939232375 seconds * `ruby bin/fluentd --enable-input-metrics -c in_tail.conf` * 67.776236261 seconds * fluentd 1.16.9 (daccbc6) * `ruby bin/fluentd -c in_tail.conf` * 106.312500419 seconds ### config ``` <source> @type tail tag test path "#{File.expand_path '~/tmp/fluentd/access-*.log'}" read_from_head true <parse> @type json </parse> </source> <match **> @type file path "#{File.expand_path '~/tmp/fluentd/log'}" </match> ``` ### script to generate 10GB ```ruby # frozen_string_literal: true require "json" require "fileutils" def data_generater(str) { "message": str * 1000, }.to_json end FILE_MAX_SIZE = 10 * 1024 * 1024 * 1024 FILE_PATH = "/home/watson/tmp/fluentd/access-1.log" dir = File.dirname(FILE_PATH) FileUtils.mkdir_p(dir) File.open(FILE_PATH, "w") do |f| data = data_generater('a') loop do f.puts data break if File.size(FILE_PATH) > FILE_MAX_SIZE end end ``` **Docs Changes**: fluent/fluentd-docs-gitbook#578 **Release Note**: The same as the title. --------- Signed-off-by: Shizuo Fujita <[email protected]> Co-authored-by: Daijiro Fukuda <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
Signed-off-by: Shizuo Fujita <[email protected]>
ce48ad9    to
    3c82dcc      
    Compare
  
    | Solved a conflict | 
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
No description provided.